Skip to content

N33 BITGUN #1010 #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2022
Merged

Conversation

shosanna
Copy link
Contributor

@shosanna shosanna commented May 6, 2022

Adding BITGUN release for the April newsletter.

Part of #1010

@shosanna shosanna changed the title Shosanna april bitgun N33 BITGUN #1010 May 6, 2022
@shosanna
Copy link
Contributor Author

shosanna commented May 7, 2022

Ehm, can anyone advice on what I did wrong with the PR? :) @ozkriff maybe? It is my first time contributing here .. Thanks!

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general 👍

though the formatting needs t be fixed

content/news/033/index.md:71 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
content/news/033/index.md:78:81 MD013/line-length Line length [Expected: 80; Actual: 160]
content/news/033/index.md:80:81 MD013/line-length Line length [Expected: 80; Actual: 100]
content/news/033/index.md:81:81 MD013/line-length Line length [Expected: 80; Actual: 116]
content/news/033/index.md:82:81 MD013/line-length Line length [Expected: 80; Actual: 139]
content/news/033/index.md:84 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AngelOnFira AngelOnFira merged commit 1976557 into rust-gamedev:source May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants